
Design comparison
SolutionDesign
Community feedback
- P@makogeborisPosted 2 months ago
Great work, some suggestions
- Use the
a
tag for these social links instead ofp
because the clicking on the links should navigate you another page and also using an unordered listul
to group the links is a better approach for both semantics and accessibility, divs aren't semantic. Here's how you can structure them
<ul class="grp-btn"> <li><a href="#" class="btn">GitHub</a></li> <li><a href="#" class="btn">Frontend Mentor</a></li> <li><a href="#" class="btn">LinkedIn</a></li> <li><a href="#" class="btn">Twitter</a></li> <li><a href="#" class="btn">Instagram</a></li> </ul>
- All content should be wrapped within landmarks. Wrap a
main
tag around the .main
Hope this helps, Good luck!
Marked as helpful0 - Use the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord