@salva-it
Posted
Congratulations on completing this challenge! I have a few suggestions:
I recommend using CSS variables for colors in the style file to allow for better management and easier changes. It is better to use the rem unit instead of em for sizing and measurements. In the profile photo section, you used position: relative, which is unnecessary. You could have positioned the image using margin instead. In the transition section, you set the duration to .01s. It's better to use .03s or .05s to ensure smooth animation transitions. The project specifies using the Inter font, but you didn't include it. I recommend adding the Google font link in your HTML file. You used the <h1> tag for the profile name, which is good. I suggest using <h2> and <h3> tags for the remaining header sections. For the social section, there is no need to use div elements. You could have created the list using just the a tags, and using target="_blank" is appropriate. The Bootstrap link comments seem unnecessary for this project, so it's better to remove them. This will make the code cleaner. It's very important to design the project to be responsive so that it displays correctly on different platforms. I recommend making the project responsive. Good luck!
Marked as helpful
@Nandakishor-M
Posted
@salva-it Thanks for your valuable suggestions.