social-links-profile

Community feedback

• 

  Salva•260

  @salva-itPosted 3 months ago

  Congratulations on completing this challenge! I have a few suggestions:

  I recommend using CSS variables for colors in the style file to allow for better management and easier changes. It is better to use the rem unit instead of em for sizing and measurements. In the profile photo section, you used position: relative, which is unnecessary. You could have positioned the image using margin instead. In the transition section, you set the duration to .01s. It's better to use .03s or .05s to ensure smooth animation transitions. The project specifies using the Inter font, but you didn't include it. I recommend adding the Google font link in your HTML file. You used the <h1> tag for the profile name, which is good. I suggest using <h2> and <h3> tags for the remaining header sections. For the social section, there is no need to use div elements. You could have created the list using just the a tags, and using target="_blank" is appropriate. The Bootstrap link comments seem unnecessary for this project, so it's better to remove them. This will make the code cleaner. It's very important to design the project to be responsive so that it displays correctly on different platforms. I recommend making the project responsive. Good luck!

  Marked as helpful

  0

  ---

  

  Nandakishor-M•30

  @Nandakishor-MPosted 3 months ago

  @salva-it Thanks for your valuable suggestions.

  0
• 

  RogerTito455•160

  @RogerTito455Posted 3 months ago

  Semantic HTML: The HTML is fairly semantic and well-structured. However, you might consider using more specific tags like <nav> for the social media links since they relate to navigation.

  You could also add a <footer> tag even if it's empty for now, which would give the page a more complete structure. Accessibility:

  Consider adding aria-label attributes to the social media links to improve accessibility, especially for users who rely on screen readers. Ensure the images have more descriptive alt attributes. Instead of just "person-photo," something like “Profile photo of Jessica Randall” would be more meaningful. Links:

  The social media links all have the same visible text. You could add a title attribute to the links to provide additional information on what happens when clicked. CSS:

  CSS Variables: You might want to use more CSS variables for colors, font sizes, and other repeated styles. This will make future maintenance easier. Grid Layout: The use of display: grid; is good, but you could specify grid-template-columns outside of the individual divs to create a more controlled and adjustable layout. Transitions: The transition time (transition: 2s) is quite long. Generally, users expect quick transitions (between 0.2s and 0.5s). Additionally, specifying exactly which properties should transition (e.g., transition: background-color 0.3s ease) can improve performance. Responsiveness:

  While the site adapts to different screen sizes, you could improve the mobile experience further. For example, using media queries to adjust the size of the card and text on smaller screens would be beneficial. Bootstrap Usage:

  Although you've commented out the inclusion of Bootstrap, if you're not using it, you could remove that line entirely to reduce file size and loading times. If you do decide to use Bootstrap, you could leverage its utilities to further simplify your CSS.

  Marked as helpful

  0

  ---

  

  Nandakishor-M•30

  @Nandakishor-MPosted 3 months ago

  @RogerTito455 Thanks.

  0