Tharun Raj• 1,250
@Code-Beaker
Posted
Hi there, congratulations on completing this challenge... You're doing a great job! 🎉
I visited your website and you've done an interesting work making the website. It looks close to the design and you've added your layer of creativity to make it look and feel better! Let me share some of my suggestions regarding your solution that might help you improve it:
- Create variables for properties that you will use multiple times. You've done this for colours. But, this can also be done to the
font-weightsandfont-sizes. Using maps will be a lot efficient when having multiple variables of the same type(eg: set of colors, set of font sizes, etc.). Here is an article that covers SCSS Maps and how to use them - Add more class names to your elements. Using class names is a much better way to style your page rather than using the element/tag selectors. This is especially handy when working on large projects.
- Putting a small vertical gap between that card and the footer might make it look better.
- NEVER set
font-sizein pixels. Here's why
Overall, you've done a great work. There is still space for improvement and I'm sure you will be able to create better and more accessible projects!
Hope this helps you... 😄
Marked as helpful
1
