Social links profile

Community feedback

• 

  Sebastian•1,580

  @dnksebastianPosted 10 months ago

  Hi Rob,

  good job on finishing the project! One minor thing which I've noticed is that instead of using a div which wraps the buttons, you might want to change it into an unordered list with anchor tags to make the code more semantic. Using <a> instead of <button> in this case sounds like a better choice because we can assume that social media links have their href attributes, buttons on the other hand should generally be used for JS interactivity :)

  Here's a condensed article covering the issue: https://css-tricks.com/a-complete-guide-to-links-and-buttons/

  Hope that helps!

  Marked as helpful

  1

  ---

  

  Rob Meijer•100

  @robmeijerPosted 10 months ago

  @dnksebastian Hi Sebastian, thank you so much for the feedback! I went back and forth between using buttons and links, and as the links don't really go anywhere, I decided on buttons instead.

  But your reasoning makes sense, and the article you linked is very useful.

  I am going to update it to have as a good example.

  Thanks again!

  1

  

  Sebastian•1,580

  @dnksebastianPosted 10 months ago

  @robmeijer For empty or placeholder links you can use href="#/" so that your page doesn't reload or jump to the top after clicking the link :)

  Marked as helpful

  1