Design comparison
SolutionDesign
Community feedback
- @vitchetPosted 4 months ago
Good job, Karim! It's looking good.
I want to give you some advice. Try using flex-box instead of margins, it would make things easier to develop and change if needed, and it makes code easier to read. When you add hover styling for links don't forget to add them for focus too, it's needed for screen readers and mobile users(you can't hover on phone). It's also good to use css variables for repeatedly used values, so you can easily change them all in future.
For everything else, very solid and clean work. Keep going!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord