Design comparison
Solution retrospective
Found this quite easy to achieve with flexbox
What challenges did you encounter, and how did you overcome them?Tried to do it with CSS grid but I think that was overkill so reverted back to flexbox
Community feedback
- @danielmrz-devPosted 5 months ago
Hello there!
Congrats on completing the challenge! ā
Your solution looks great!
š It's recommended to use semantic HTML elements like
<ul>
and<li>
for creating lists. This ensures that your code is more accessible, maintainable, and semantically meaningful.Here's and example on how you can refactor your code:
After Refactoring
<ul class="list-container"> <li><a href="#">Github</a></li> <li><a href="#">Frontend Mentor</a></li> <li><a href="#">LinkedIn</a></li> ... </ul>
By using
<ul>
and<li>
, you convey the structure of your content more clearly, making it easier for screen readers and search engines to understand. Additionally, it aligns with best practices for HTML semantics.I hope you find this helpful!
Keep up the excellent work!
0 - @Alex-Archer-IPosted 5 months ago
Hi!
I can give you a couple suggestions of how to improve your work. You missed a few semantic tags. First of all it's a
main
tag. Every page should contain one. Than, the list of links should be theul
tag withli
inside. And since they are the links and not interactive elements it's better to use ana
tags here.<ul> <li><a href="#">It's a link here!</a></li> <li><a href="#">It's a link here!</a></li> <li><a href="#">It's a link here!</a></li> <li><a href="#">It's a link here!</a></li> <li><a href="#">It's a link here!</a></li> </ul>
Also I recommend you to use
rem
for font size as it's value depends of users settings. By default1rem=16px
.Hope that could help. Cool work at all, happy coding =)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord