Social Links Profile

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 5 months ago

  Hello there!

  Congrats on completing the challenge! ✅

  Your solution looks great!

  📌 It's recommended to use semantic HTML elements like <ul> and <li> for creating lists. This ensures that your code is more accessible, maintainable, and semantically meaningful.

  Here's and example on how you can refactor your code:

  After Refactoring

  <ul class="list-container">
      <li><a href="#">Github</a></li>
      <li><a href="#">Frontend Mentor</a></li>
      <li><a href="#">LinkedIn</a></li>
      ...
  </ul>
  

  By using <ul> and <li>, you convey the structure of your content more clearly, making it easier for screen readers and search engines to understand. Additionally, it aligns with best practices for HTML semantics.

  I hope you find this helpful!

  Keep up the excellent work!

  0
• 

  Alex•3,130

  @Alex-Archer-IPosted 5 months ago

  Hi!

  I can give you a couple suggestions of how to improve your work. You missed a few semantic tags. First of all it's a main tag. Every page should contain one. Than, the list of links should be the ul tag with li inside. And since they are the links and not interactive elements it's better to use an a tags here.

  <ul>
      <li><a href="#">It's a link here!</a></li>
      <li><a href="#">It's a link here!</a></li>
      <li><a href="#">It's a link here!</a></li>
      <li><a href="#">It's a link here!</a></li>
      <li><a href="#">It's a link here!</a></li>
  </ul>
  

  Also I recommend you to use rem for font size as it's value depends of users settings. By default 1rem=16px.

  Hope that could help. Cool work at all, happy coding =)

  0