Social links profile

Community feedback

• Account deleted

  Hi JoyObaidu,

  I wanted to share some feedback regarding this challenge.

  • Use the <article> tag for defining independent content -- in this case, the profile card.

  • Avoid nesting the p tag inside a span tag since the p tag is a block-level element. It's best to use div for grouping content for both inline and block-level elements instead of span for the different parts of the code below:

  <span class="name">
          <p>Jessica Randall</p>
        <b> London, United Kingdom</b>
        </span>
  

  <span class="links">
        <a href="#"> GitHub</a>
        <a href="#">Frontend Mentor</a>
        <a href="#"> LinkedIn</a>
        <a href="#">Twitter</a>
        <a href="#"> Instagram</a>
       </span>
  

  • Also, include a heading tag on your card. At this part: <p>Jessica Randall</p>, I suggest switching the p tag to an h1 tag.

  • To use the font files, use the @font-face rule in your CSS to set up the font.

  @font-face {
    font-family: [any font name];
    src: url([font url]);
  }
  
  /* Now you can use the font in your page */
  
  body {
    font-family: [the font name used in @font-face];
  }
  

  I hope you find this feedback helpful. Good luck with your next challenge!

  0