Skip to content
Submitted 6 months ago

Social Links Profile

Paweł Kasprzak•90
@pkasprzak9
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social links profile
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I'd spend more time on reading about relative and non-relative units.

What challenges did you encounter, and how did you overcome them?

I had to read a lot about variable fonts.

What specific areas of your project would you like help with?

I'd like to know if i'm using units properly.

Community feedback

  • Alex•3,130
    @Alex-Archer-IPosted 6 months ago

    Hi!

    I can suggest you to use min-height on the main element instead of just height. This is necessary in case if user's screen will be smaller than content of the page. Also, try not to explicitly specify the height of a container (in your case it's the .card element). It'll be better if it's height will depends of the content as in real projects content might change time to time.

    Oh, I see you are using variable fonts! I've learned about them recently and they're cool =)

    So, well done, good job, keep doing =)

    Marked as helpful
    0
    Paweł Kasprzak•90
    @pkasprzak9Posted 6 months ago

    Thanks @Alex-Archer-I! I had that feeling that something was wrong but wasn't sure what it was. It's much more clear right now!

    1
    Alex•3,130
    @Alex-Archer-IPosted 6 months ago

    @pkasprzak9

    Well, that's not exactly "wrong", it's more like "stuff which can be done a bit better way" =)

    Glad I could help =)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord