@TedJenkler
Posted
Nice project! Here are a few suggestions for improvement:
-
No, adding more elements will only make it harder for screen readers. With aria-labels for the links, screen readers will get the content without any problem. Using <ul> and <ol> will just require more CSS and isn’t necessary since it’s not really a list. aria-label="How to reach me" or something similar would be an improvement.(On the parent div)
-
Flexbox is the most suitable method to style the card, although you could use Grid for styling the links, but it would involve extra work. Flexbox is ideal for flexible designs, while Grid is better when the parent controls the size of all children, making them the same size or consistently sized.
-
I’m actually unsure about this one, so I’ll skip it. Arguably, I don't see a reason to clamp this card.
-
The page isn't tabbable or using arrows, so something might be wrong if that was the intention. I would argue that the focus is too thick; 1 or 2 would be sufficient.
-
Yes, in most cases, that’s a good idea but isn’t really needed here. It makes the most difference in forms.
Keep up the great work!
Best, Teodor
Marked as helpful