@coding-vasu
Posted
Great!
1. Semantic HTML & ARIA
a. Use ARIA like below -> <main aria-label="Jessica Randall's profile card">
b. Specify the role attribute for unordered list html <ul role="list">
2. Accessible
a. While using tab the buttons are not changing color like its happening on hover.
you can add focus
pseudo code
3. Layout is Responsive
4. Code is well Structured
Overall its looks great!
Marked as helpful
@RealKendpr
Posted
@coding-vasu Thank your feedback. Although the 1b: Specify the role attribute for unordered list html <ul role="list">
I don't think that should be specify as a list, since Im already using <u/l>
. Dont the browser already know that its a list?
@coding-vasu
Posted
@RealKendpr, you are correct we don't need, since we are already using ul
Thank you