Skip to content
Submitted about 1 month ago

Social links profie

Rido Septiawan•100
@riddsep
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social links profile
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

quite similar to the design provided

What challenges did you encounter, and how did you overcome them?

The biggest challenge was that the figma design didn't exist so I worked on it based on the existing design photos

Community feedback

  • Ineke•80
    @Ineke84Posted about 1 month ago

    Hi Rido,

    Your solution looks good and I did see some things I could improve in my own solution.

    One of the points in the challenge was to make sure visitors could go through the buttons with their keyboard. The focus that's on the buttons then (white outline) is different from your hover (lime green). Did you mean this to be different?

    At the moment there is quite some styling in the html index file itself. I myself find it easier to put this in a seperate css file.

    Hope this helps.

    Regards, Ineke

    Marked as helpful
    1
    Rido Septiawan•100
    @riddsepPosted about 1 month ago

    @Ineke84 thanks mate, I've tried changing what you suggested, but I did it on purpose for a separate style

    0
  • Steven Stroud•11,870
    @StroudyPosted about 1 month ago

    Exceptional work! You’re showing great skill here. I’ve got a couple of minor suggestions that could make this stand out even more…

    • Using a <main> tag inside the <body> of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content.

    • Having a clear and descriptive alt text for images is important because it helps people who use screen readers understand the content, making your site more accessible. It also improves SEO, as search engines use alt text to understand the image's context, helping your site rank better, Check this out Write helpful Alt Text to describe images,

              <img
            src="assets/images/avatar-jessica.jpeg"
            alt=""
            class="card-image"
          />
    • I would put these into a <ul> <li>, and the text should be wrapped with a <a> so it is accessible with a keyboard using the tab key, Using an <a> tag for navigation is semantically correct, improves accessibility for screen readers, and ensures consistent behavior across browsers, unlike a <button> or a <div> not intended for links.
            <div class="card-body">
          <button>GitHub</button>
          <button>Frontend Mentor</button>
          <button>LinkedIn</button>
          <button>Twitter</button>
          <button>Instagram</button>
        </div>

    • Using font-display: swap in your @font-face rule improves performance by showing fallback text until the custom font loads, preventing a blank screen (flash of invisible text). The downside is a brief flash when the font switches, but it’s usually better than waiting for text to appear.

    • I think you can benefit from using a naming convention like BEM (Block, Element, Modifier) is beneficial because it makes your CSS more organized, readable, and easier to maintain. BEM helps you clearly understand the purpose of each class, avoid naming conflicts, and create reusable components, leading to a more scalable codebase. For more details BEM,

    • While px is useful for precise, fixed sizing, such as border-width, border-radius, inline-padding, and <img> sizes, it has limitations. Pixels don't scale well with user settings or adapt to different devices, which can negatively impact accessibility and responsiveness. For example, using px for font sizes can make text harder to read on some screens, Check this article why font-size must NEVER be in pixels. In contrast, relative units like rem and adjust based on the user’s preferences and device settings, making your design more flexible and accessible. Use px where exact sizing is needed, but prefer relative units for scalable layouts. If you want a deeper explanation watch this video by Kevin Powell CSS em and rem explained. Another great resource I found useful is this px to rem converter based on the default font-size of 16 pixel.

    I hope you’re finding this guidance useful! Keep refining your skills and tackling new challenges with confidence. You’re making great progress—stay motivated and keep coding with enthusiasm! 💻

    0
    Rido Septiawan•100
    @riddsepPosted about 1 month ago

    @Stroudy thanks for ur advice mate!

    1
    Steven Stroud•11,870
    @StroudyPosted about 1 month ago

    Hey @riddsep, You got this! 💪

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord