@Alex-Archer-I
Posted
Hi! Interesting work, it's always cool to experiment with design =)
Here is a few tips:
- Use
min-height
instead ofheight
on thebody
tag in case if the user's devise have smaller screen than content. - Almost the same about
.article
- try not to explicitly set height for container elements. In real projects there could be the cases when content might changed, so it's better whenheight
of a container depends on the content. - It is better use
ul
andli
tags for the buttons-links because of semantic. To keep html leaner you could puta
directly intoli
, buttons aren't really necessary here.
Oh, and the padding
property haven't auto
value.
Anyway, cool job, keep doing =)
Marked as helpful
@maxnoelp
Posted
@Alex-Archer-I thanks for ur comment, i learn since 2 weeks. I will keep in my mind :)
@Alex-Archer-I
Posted
@maxnoelp That's cool, good luck with your studying =) Fell free to ask or comment if you need =)
@maxnoelp
Posted
@Alex-Archer-I thanks, it is a lot to learn :) I may take you up on that later.