Social links page using basic html css js

Community feedback

• 

  Boris•2,850

  @mkborisPosted 3 months ago

  Great work @NOTyuvraj, here are some suggestions

  • All content should be wrapped within landmarks. Wrap a main tag around the main-box
  • To improve the semantic meaning of these social media links, you should use the a (anchor) tag instead of the button tag. The a tag is used for navigation to other pages, while the button tag is designed for interactive actions like submitting forms or for events like toggling content. Also, using an unordered list ul to group the social media links is a better approach for both semantics and accessibility.
  • The text content in these div elements (Name, location and description) should be semantically wrapped in more appropriate HTML tags like headings h2 or paragraphs p for better accessibility and structure.
  • Use a class instead of an ID for styling to keep specificity low, reserve IDs for JavaScript manipulation.
  • Use a separate file for your CSS as it improves maintainability.
  • Change the height of the body to min-height Using min-height ensures the content can grow beyond the viewport height if necessary, while height would restrict it to exactly the viewport height, potentially causing overflow issues with content that exceeds this height.
  • Avoid setting fixed heights and widths on elements, as this can create problems with responsiveness and content fit. Instead, let the content and padding determine the element’s size. If necessary, use max-width or min-height. Change the width of the .#main-box to max-width. Also remove the height completely and add some padding bottom.
  • Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
  • Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.

  Hope this helps. Good luck

  Marked as helpful

  1
• 

  P

  Teodor Jenkler•3,820

  @TedJenklerPosted 3 months ago

  Hi @NOTyuvraj,

  Nice project! Here are a couple of additional recommendations:

  OG Meta Tags: I strongly recommend using OG (Open Graph) meta tags to improve SEO and the shareability of your site. Proper OG tags can significantly impact how your site appears when shared on social media and can make a difference in search engine ranking, potentially even affecting whether your site appears in search results.

  ARIA Labels: When semantic HTML elements aren't applicable, make sure to add aria-label attributes to your <div> elements. This practice enhances accessibility and contributes positively to SEO by helping screen readers understand the content and purpose of these elements.

  Keep up the great work!

  Best, Teodor

  1