@mkboris
Posted
Great work @NOTyuvraj, here are some suggestions
- All content should be wrapped within landmarks. Wrap a
main
tag around the main-box - To improve the semantic meaning of these social media links, you should use the
a
(anchor) tag instead of thebutton
tag. Thea
tag is used for navigation to other pages, while thebutton
tag is designed for interactive actions like submitting forms or for events like toggling content. Also, using an unordered listul
to group the social media links is a better approach for both semantics and accessibility. - The text content in these
div
elements (Name, location and description) should be semantically wrapped in more appropriate HTML tags like headingsh2
or paragraphsp
for better accessibility and structure. - Use a class instead of an ID for styling to keep specificity low, reserve IDs for JavaScript manipulation.
- Use a separate file for your CSS as it improves maintainability.
- Change the
height
of the body tomin-height
Using min-height ensures the content can grow beyond the viewport height if necessary, while height would restrict it to exactly the viewport height, potentially causing overflow issues with content that exceeds this height. - Avoid setting fixed
heights
andwidths
on elements, as this can create problems with responsiveness and content fit. Instead, let the content and padding determine the element’s size. If necessary, usemax-width
ormin-height
. Change the width of the .#main-box tomax-width
. Also remove theheight
completely and add some padding bottom. - Font-size should be written in
rem
not px. This article explains it better Why font-size must NEVER be in pixels. - Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.
Hope this helps. Good luck
Marked as helpful