Social links page

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 6 months ago

  Hello there!

  Congrats on completing the challenge! ✅

  Your solution looks great!

  📌 It's recommended to use semantic HTML elements like <ul> and <li> for creating lists. This ensures that your code is more accessible, maintainable, and semantically meaningful.

  Here's and example on how you can refactor your code:

  After Refactoring

  <ul class="list-container">
      <li><a href="#">Github</a></li>
      <li><a href="#">Frontend Mentor</a></li>
      <li><a href="#">LinkedIn</a></li>
      ...
  </ul>
  

  By using <ul> and <li>, you convey the structure of your content more clearly, making it easier for screen readers and search engines to understand. Additionally, it aligns with best practices for HTML semantics.

  I hope you find this helpful!

  Keep up the excellent work!

  Marked as helpful

  0
• 

  Victoria Azola Silva•1,290

  @VickyAzolaPosted 6 months ago

  This comment was deleted 6 months ago

  0

  ---

  

  Codelearner123456•40

  @Codelearner123456Posted 6 months ago

  @VickyAzola It does help but most of what you just said doesn't work for the project because I use Microsoft Edge to see what my project looks like.

  0
• 

  P

  ZeroCool989•30

  @ZeroCool989Posted 6 months ago

  The design looks great. Just a couple of quick suggestions to make it even better:

  Centering: It might look more balanced if the header "Jessica Randall" and the subtitle are more centered within the card and also to Center the whole card it looks a little more left than center.

  Footer Adjustment: Consider moving the footer information out of the main container that it look more like the original.

  Really cool work so far! Keep it up!

  Marked as helpful

  0

  ---

  

  Codelearner123456•40

  @Codelearner123456Posted 6 months ago

  @ZeroCool989 thank you for your help.

  0