Social Links Page

Community feedback

• 

  P

  Steven Stroud•11,870

  @StroudyPosted about 2 months ago

  Awesome job tackling this challenge! You’re doing amazing, and I wanted to share a couple of suggestions that might help refine your approach…

  • I would put these into a <ul> <li>, and the text should be wrapped with a <a> so it is accessible with a keyboard using the tab key, Using an <a> tag for navigation is semantically correct, improves accessibility for screen readers, and ensures consistent behavior across browsers, unlike a <button> or a <div> not intended for links.

        <div class="link-area">
          GitHub
        </div>
        <div class="link-area">
         Frontend Mentor
        </div>
        <div class="link-area">
          LinkedIn
        </div>
        <div class="link-area">
          Twitter
      </div>
      
  

  • For future project, You could downloading and host your own fonts using @font-face improves website performance by reducing external requests, provides more control over font usage, ensures consistency across browsers, enhances offline availability, and avoids potential issues if third-party font services become unavailable. Place to get .woff2 fonts

  • Developers should avoid using pixels (px) because they are a fixed size and don't scale well on different devices. Instead, use rem or em, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained.- Another great resource for px to rem converter.

  • Using max-width: 100% or min-width: 100% is more responsive than just width: 100% because they allow elements to adjust better to different screen sizes. To learn more, check out this article: responsive-meaning.

  I hope you found this advice helpful! Keep up the great work, You’re doing amazing, and I can’t wait to see what you create next. Happy coding! 🚀

  Marked as helpful

  0

  ---

  

  Danyal Sarwar•30

  @DanyalSarwar325Posted about 2 months ago

  @Stroudy Thankyou very much .I will do better next time

  0

  

  P

  Steven Stroud•11,870

  @StroudyPosted about 2 months ago

  Hey @DanyalSarwar325, You did great this time, Just some small improvement for accessibility and responsiveness. You got this💪

  Marked as helpful

  0
• 

  MikDra1•6,920

  @MikDra1Posted about 2 months ago

  If you want to make your card responsive with ease you can use this technique:

  .card {
  width: 90%;
  max-width: 37.5rem;
  }
  

  On the smaller screens card will be 90% of the parent (here body), but as soon as the card will be 37.5rem (600px) it will lock with this size.

  Also to put the card in the center I advise you to use this code snippet:

  .container {
  display: grid;
  place-items: center;
  }
  

  Hope you found this comment helpful 💗💗💗

  Good job and keep going 😁😊😉

  0