Social links

Community feedback

• 

  Boris•2,850

  @mkborisPosted 3 months ago

  Here are a few things to review

  • All content should be wrapped within landmarks. Wrap a main tag around the .card and a footer for the attribution.
  • Change the height of the body to min-height, using min-height ensures the content can grow beyond the viewport height if necessary, while height would restrict it to exactly the viewport height, potentially causing overflow issues with content that exceeds this height.
  • It's best practice linking Google fonts directly in the HTML head section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times.
  • Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.
  • Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.

  Marked as helpful

  0
• 

  P

  Darkstar•1,100

  @DarkstarXDDPosted 3 months ago

  Looks nice. Some suggestions.

  • Every page must have a <main> landmark element wrapping the main content of the page.
  • The attribution should go inside a <footer> landmark element, which will be outside of the <main>.
  • I would use a <h2> for the user's name here. It acts as a heading for the content that comes after it.
  • Use rem for font-sizes. If the user change their browser font size, the text in your site won't react to it because your font-sizes are in px. If you have the font-sizes in rem, text in your webpage will scale according to the the users preferred browser font size. I would use rem for max-width too.
  • Do you need the div that wraps the <p> element which contains the user's bio? I think it's not needed. <p> element alone is fine. Try to keep the HTML simple.

  Marked as helpful

  0