Boris• 2,870
@mkboris
Posted
Here are a few things to review
- All content should be wrapped within landmarks. Wrap a
main
tag around the .card and afooter
for the attribution. - Change the
height
of the body tomin-height
, usingmin-height
ensures the content can grow beyond the viewport height if necessary, while height would restrict it to exactly the viewport height, potentially causing overflow issues with content that exceeds this height. - It's best practice linking Google fonts directly in the HTML
head
section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times. - Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.
- Font-size should be written in
rem
not px. This article explains it better Why font-size must NEVER be in pixels.
Marked as helpful
0