@rahulkumar215
Posted
Hello Srishti👋
Congratulations on successfully completing the challenge! 🎉
-
Your code is well written and your colour choice is good.
-
However, your footer section blends with background and is hard to see.
-
also when writing
media-query
, try usingem
units rather thanpx
, for all browsers and devices view consistency
like this :-
@media screen and (max-height: 720px) { }
to
@media screen and (max-height: 45em) { }
just divide px
value to 16 and you have em
value.
writing media query in em
is best practice.
If you need any feedback or suggestions, I am happy to help
Good Work, Keep Grinding and Have Fun Coding!
Marked as helpful
@itsmesrishti
Posted
@rahulkumar215 Thank you for the tips!
I'll keep in mind the contrast for the footer next time! And wow I didn't know that it's considered good practise to use em for media queries!
I'll try to implement these things in my next project! Thank you!