Social links css vanilla

Community feedback

• 

  Youssef•210

  @DORMODOPosted 5 months ago

  Hi Roni, Great job on completing the challenge! 🎉 Your attention to detail.

  A couple of suggestions for improvement:

  1.Use Semantic Elements: Consider replacing the div with nav for the social links section. This could enhance the accessibility and structure of your code. 👍

  <nav class="social-links">
      <ul class="menu-links">
        <li class="link__social"><a class="link" href="#">GitHub</a></li>
           ...
        <li class="link__social"><a class="link" href="#">Instagram</a></li>
      </ul>
  </nav>
  

  2.Use figcaption for Descriptive Text: Moving the h1, location, and description into a figcaption within the figure tag can improve semantic meaning and accessibility. 💡

  <figure class="presentation__figure">
        <img src="">
        <figcaption class="presentation__caption">
                 ... 
        </figcaption>
  </figure>
  

  You’re doing an incredible job, and each project you complete is a step forward. 🚀 Keep pushing your limits and experimenting with new techniques.

  Keep up the fantastic work! 👏

  0