Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social links css vanilla

Roni Tovarβ€’ 270

@ronitzdev

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Youssefβ€’ 210

@DORMODO

Posted

Hi Roni, Great job on completing the challenge! πŸŽ‰ Your attention to detail.

A couple of suggestions for improvement:

1.Use Semantic Elements: Consider replacing the div with nav for the social links section. This could enhance the accessibility and structure of your code. πŸ‘

<nav class="social-links">
    <ul class="menu-links">
      <li class="link__social"><a class="link" href="#">GitHub</a></li>
         ...
      <li class="link__social"><a class="link" href="#">Instagram</a></li>
    </ul>
</nav>

2.Use figcaption for Descriptive Text: Moving the h1, location, and description into a figcaption within the figure tag can improve semantic meaning and accessibility. πŸ’‘

<figure class="presentation__figure">
      <img src="">
      <figcaption class="presentation__caption">
               ... 
      </figcaption>
</figure>

You’re doing an incredible job, and each project you complete is a step forward. πŸš€ Keep pushing your limits and experimenting with new techniques.

Keep up the fantastic work! πŸ‘

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord