Boris• 2,870
@mkboris
Posted
Great job on completing this challenge, Flexbox and Grid are effective for responsive layouts which you already applied to your solution, also using media queries for applying styles based on screen size. min/max width should be used to ensure elements scale within specified limits and should not be set using fixed units. You will rarely need to set heights as you should let the element's content and padding determine it's size.
Some suggestions for your solution
- All content should be wrapped within landmarks. Wrap a
maintag around your card. - Your card's max-width should be in rem
- Font-size should be written in rem.
Marked as helpful
0
