Social Links

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 10 months ago

  Hello @MiyaoCat!

  Your project looks great!

  I have a few suggestions for you to reduce unnecessary code:

  📌 Remove these lines from your code:

  .social-card {
      margin-left: auto; 
      margin-right: auto;
      margin-top: 80px; 
  }
  
  main {
      width: 85vw;
      flex-grow: 1;
  }
  

  Since you already centered the card using a few properties on the body, there's no need for using margin or setting a specific width for the container. You can just remove those lines 😊

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  0

  ---

  

  John•410

  @MiyaoCatPosted 10 months ago

  Thanks for catching that! I've removed them. @danielmrz-dev

  1
• 

  Aykın Sancaklı•680

  @aykinsancakliPosted 10 months ago

  Hi @MiyaoCat,

  Great work!

  • If it is doing something (like open a pop-up window, submit a form etc.) it should be a button
  • If it leads you somewhere (links, page navigation etc) it should be a link.

  In this case, they are all social links so it is appropriate to use a link.

  I hope this helps

  Cheers,

  Aykın

  Marked as helpful

  0

  ---

  

  John•410

  @MiyaoCatPosted 10 months ago

  That makes sense. Thanks! @aykinsancakli

  1