Design comparison
SolutionDesign
Community feedback
- @StroudyPosted about 2 months ago
Hey, Fantastic job, Found it hard to give any feedback, Great job with this solution you should be proud, A few things I noticed,
- Missing a
<meta>
description tag for SEO purposes, - Setting a height and width attribute to your
<img>
will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image, - Incorrect spelling
<p class="adress">London, United Kingdom</p>
address, - It is best practice to use
margin-inline: auto;
to center left and right then than justmargin: auto;
(Inline just means left to right, The up and down should be set with flex),
I hope you found some of this information helpful, I look forward to seeing some more from you, Happy coding! 💻
Marked as helpful0 - Missing a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord