Tharun Raj• 1,290
@Code-Beaker
Posted
Hi friend! 👋 Congratulations on completing this challenge 👏🥳
I have noted down a few points while I visited your website and source code and I would like to share it with you and help you improve your solution.
- Instead of using pixels, use relative units like
rem
to make it easier to make the website responsive for different screens. - There's no need of these lines of code:
body {
width: 100%;
height: 100%;
}
The body
element already takes the full width and height of the document and hence it doesn't make any difference. Same applies to the main
element.
- The links should be wrapped in
a
tags and notbutton
tags. They're meant to be links that take you to an external website. Right now, they're set to be buttons and do not serve their actual purpose. - You can use CSS Custom Properties and avoid writing the same thing again and again for CSS properties. Here's a guide on Getting started with CSS Custom Properties
- NEVER set
font-size
in pixels. Read this.
That's what I've got for you. I hope you found these helpful! 😊
0