Design comparison
Solution retrospective
That I didn't give up on this project, thanks @Pipendog for your help.
What challenges did you encounter, and how did you overcome them?I added too many br's in my html, it was messing up my whole container. I rushed this project in the end, while I should have been making sure that I make less mistakes - I will try to focus more on reviewing my stuff before I ask other people for help.
What specific areas of your project would you like help with?None but any advice or suggestions are much appreciated.
Community feedback
- @danielmrz-devPosted 6 months ago
Hello there!
Congrats on completing the challenge! β
Your project is looking fantastic!
I'd like to suggest a way to make it even better:
- Using
margin
isn't always the most effective method for centering an element.
Here's a highly efficient approach to position an element at the center of the page both vertically and horizontally:
π Apply this CSS to the body (avoid using
position
ormargins
in order to work correctly):body { min-height: 100vh; display: flex; justify-content: center; align-items: center; }
I hope you find this helpful!
Keep up the excellent work!
Marked as helpful0@DanielfwwPosted 6 months ago@danielmrz-dev thank you sir - I will try to implement that in my next project.
1 - Using
- @Alex-Archer-IPosted 6 months ago
HI! Well done, your work quite similar to original design!
I can recommend you to use one class name for the identical elements - like just
.button
in your case. It'll help to reduce your css code and make it more readability. Also you can reduce margin-left and margin-right tomargin: 0 auto
.Hope that helps. Keep doing =)
1 - @ERFAN-REVENANTPosted 4 months ago
Hey Dan P.- great job on finishing this project. If I had to recommend anything here, I would suggest you would use the following to center your div to the middle of the page:
body { min-height: 100vh; display: flex; justify-content: center; align-items: center; }
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord