Social links

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 9 months ago

  Hello @kirstiAnja!

  Your solution looks excellent!

  I have just one suggestion:

  • Use <main> to wrap the main content instead of <main> and <section>.

  📌 The tag <section> would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.

  This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  1

  ---

  

  Kirsti Anja Simonsen•70

  @kirstiAnjaPosted 9 months ago

  Thank you for your feedback @danielmrz-dev It is very good for my learning to have this feedbacks. You give good explanations, that helps me see things in other ways.

  1
• 

  Hassan Moataz•1,860

  @hassanmoaaPosted 9 months ago

  Hello @kirstiAnja !

  Great Job solving the challenge mate *congrats * 🎉

  Some suggestions for improvement!

  For the font-size it's is better to use rems and ems but px for this project is no big deal.

  font-size: 14px;

  • i see you using pixels for many elements, never use pixels for font-sizes in any element, here's why:

  • Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.

  Which properties are affected?

  All of these properties must never ever be declared in pixels:

  • font-size
  • line-height
  • letter-spacing

  If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!

  • You should use ems, and rems for font-sizes would be better

  This article may help:

  https://fedmentor.dev/posts/font-size-px/

  Other than that you're good, keep up the good work!

  1
• 

  Kirsti Anja Simonsen•70

  @kirstiAnjaPosted 9 months ago

  Thank you @hassanmoaa! I most appreciate the feedback and when looking in my code I can see that I need to focus better on my units. So I'l take your advice into consideration and let this help me code better responsive webpages.

  0