Social Linkes Profile Main Solution

Community feedback

• 

  P

  Justin Connell•720

  @justinconnellPosted 10 months ago

  Your solution looks great!

  I viewed it on various screen sizes and the layout is consistent and active states are applied appropriately - nicely done!

  Looking at the HTML I noticed that you make good use of some semantic markup like header and section - the only thing that stood out at a glance is that you can replace the root div with a main element. While on the topic of div - the link list should be implemented as an unordered list ul with list items li - the reason being that div has no markup meaning (aka not semantic) where as <ul><li></li></ul> has meaning ( it's a list ). Another thing is that links need to be implemented as links that is use a for links.

  Other than that, great work!

  I hope you find this feedback useful,

  Keep on coding!

  Marked as helpful

  1