
Design comparison
Solution retrospective
used :root in css to setup colors schema from project and also font sizes.
What challenges did you encounter, and how did you overcome them?pixel perfect, size of the fonts
Community feedback
- @MatiasTsPosted 6 days ago
Hello, Eurico. You did a great job. This is what I can contribute.
- Make a habit of including a modern CSS Reset at the top of the stylesheet.
-Using the <main> container instead of the <body> to align the content of the page is better because it gives more control over the layout, prevents global styles from affecting everything, and makes the design easier to manage and scale.
-
Set the
font-family: 'Inter', sans-serif;
in the body so you don't have to apply it to each element individually, just once. -
Font size should generally not be in px, as this can be an accessibility issue. It prevents the font from scaling with the user's default browser settings. Instead, use rem for better scalability and accessibility
-
Paragraphs have a default value of font-weight: 400, so there is no need to declare it.
-
The buttons don't need Flexbox. Just add padding on all sides (more on the width than the height) and set the width to 100%. The text will center itself automatically.
0 - @spalquiPosted 6 days ago
Great use of semantic tags and structure of your HTML document.
Your CSS code show good knowledge of modern CSS features. I like how you use CSS variables for values that are shared and common in the project such as colours and font sizes. Although the CSS looks great it could be further optimised by setting the font-family a an higher level tag such as
html
and let inheritance do its thing.Overall it's a great solution and well structured. Keep up the great work!
0 - P@kindlypi8MCeN7Posted 6 days ago
Bigger font-size, but you noticed it. Otherwise very good job !
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord