Social link profile

Community feedback

• 

  P

  Øystein Håberg•10,650

  @Islandstone89Posted 10 months ago

  Hi Mamadou. Here is my feedback, I hope it helps :)

  HTML:

  • Move the CSS for the .attribution to the CSS file, where it belongs.

  • It is common to use classes instead of IDs.

  • The image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of Jessica Randall" would be read like this: "image, image of Jessica Randall".

  • Replace the <span> elements with <p>.

  • The social links are links, not buttons. So, wrap them in an <a> tag.

  CSS:

  • It's good practice to include a CSS Reset at the top.

  • font-size must never be in px. This is bad for accessibility, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

  • Don't use complex selectors like#about-part div:nth-child(2) - it is hard to read, and it increases specificity. Instead, add a class on the <div> and target that.

  Marked as helpful

  0

  ---

  

  Mamadou•110

  @404diabyPosted 10 months ago

  Hello @Islandstone89 !! . Thanks you for comment, your advice. It helped me a lot. I will try to apply it in future projects

  1