Design comparison
Community feedback
- @WhythreePosted 3 months ago
Overall, this is a great project with a solid foundation. There are a few areas where you can improve to make it even better.
You use main and section, which is good.
<main> <section class="profile"> <div class="container"> </div> </section> </main>
But the <div class="container"> is unnecessary. It serves no purpose, not even in your styling
Same with
<div> <img src="/assets/images/avatar-jessica.jpeg" alt=""> </div>
You can style the image directly
Then you use an h1, but in your css you target a h2. Probably a typo but it is why your heading is not aligned.
<div> <button>Github</button> <button>Frontend Mentor</button> <button>Linkedln</button> <button>Twitter</button> <button>Instagram</button> </div>
Better to use <a> tags here, since these buttons link to other webpages and don't trigger an action like submitting a form: Also since you are listing a bunch of these links, why not use an unordered list
It could look like this
<ul> <li> <a href="#"> GitHub </a> </li> <li> <a href="#"> Frontend Mentor </a> </li> <li> <a href="#"> LinkedIn </a> </li> <li> <a href="#"> Twitter </a> </li> <li> <a href="#"> Instagram </a> </li> </ul>
Although you import the fonts at the start of your css, you don't use them anywhere. Try to use font-family and font-weight to more accurately reflect the design.
Keep up the good work, and these adjustments will help polish your project further!
Marked as helpful0@Thomson-pPosted 3 months ago@Whythree thanks for the insights, I'll make sure to improve on the suggested areas.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord