Design comparison
Solution retrospective
Social link profile screenshot with hover effect. Kindly check it.
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @Syyednaila535!
Your solution looks excelent!
I have just one suggestion:
š In order to make your HTML code more semantic, don't skip heading levels - start with
<h1>
, then use<h2>
, and so on..Unlike what most people think, it's not just about the size and weight of the text.
-
The
<h1>
to<h6>
tags are used to define HTML headings. -
<h1>
defines the most important heading. -
<h6>
defines the least important heading. -
Only use one
<h1>
per page - this should represent the main heading/title for the whole page.
All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful0 -
- @gfunk77Posted 10 months ago
Hi! Nice job on your solution. The card looks really nice!
I'll just mention a few things to consider:
- on the body use
min-height: 100vh
and remove the width. Width is by default 100%; - on #container you have an
align-items: center
anddisplay: block
. align-items is a flex-box property so in order for that to have any effect, you needdisplay: flex
. - on * you also have an align-items: center, you should remove that one too.
Nice job once again. I hope these suggestions were helpful.
Marked as helpful0 - on the body use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord