Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

social link profile using flexbox

mkhantkā€¢ 120

@mkhantk

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I'm getting more familiar with CSS and Flexbox.

What challenges did you encounter, and how did you overcome them?

I got stuck in the middle of the process on how to max the width of the links. I found the answer eventually with the help of google search.

What specific areas of your project would you like help with?

I appreciate every feedback and opinion. They will be a huge help to me. Thanks.

Community feedback

Daniel šŸ›øā€¢ 44,230

@danielmrz-dev

Posted

Hello @mkhantk!

Your solution looks great!

šŸ“Œ It's recommended to use semantic HTML elements like <ul> and <li> for creating lists. This ensures that your code is more accessible, maintainable, and semantically meaningful.

Here's and example on how you can refactor your code:

After Refactoring

<ul class="list-container">
    <li><a href="#">Github</a></li>
    <li><a href="#">Frontend Mentor</a></li>
    <li><a href="#">LinkedIn</a></li>
    ...
</ul>

By using <ul> and <li>, you convey the structure of your content more clearly, making it easier for screen readers and search engines to understand. Additionally, it aligns with best practices for HTML semantics.

I hope you find this helpful!

Keep up the excellent work!

Marked as helpful

1

@0xabdulkhaliq

Posted

Hello there šŸ‘‹. Congratulations on successfully completing the challenge! šŸŽ‰

  • I have a suggestion regarding your code that I believe will be of great interest to you.

MAKING ACCESSIBLE LINKS:

  • The links like Github, Frontend Mentor are needed to be actual <a> elements.
  • This is the current markup,
<div class="social">GitHub</div>
<div class="social">Frontend Mentor</div>
...
  • In order to make this solution accessible, we need to use <a> elements with href attribute. Here's the example
<a href="#" class="social">GitHub</a>
<a href="#" class="social">Frontend Mentor</a>
....
  • Additionally you need to add display: block rule for social so that we could properly place the socials on component.
  • If you have any questions or need further clarification feel free to reach out to me.

.

I hope you find this helpful šŸ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord