Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I managed to explain well to a friend how to do it.
What challenges did you encounter, and how did you overcome them?I didn't get stuck in any obstacles :)
What specific areas of your project would you like help with?None
Community feedback
- @0xabdulkhaliqPosted 7 months ago
Hello there š. Congratulations on successfully completing the challenge! š
- I have a suggestion regarding your code that I believe will be of great interest to you.
CSS šØ:
- Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using
margin
orpadding
.
- We don't need to use
margin
andpadding
to center the component both horizontally & vertically. Because usingmargin
orpadding
will not dynamical centers our component at all states
- To properly center the component in the page, you should use
Flexbox
orGrid
layout. You can read more about centering in CSS here š.
- For this demonstration we use css
Grid
to center the component.
body { min-height: 100vh; display: grid; place-items: center; }
- Now remove these styles, after removing you can able to see the changes
body { margin-top: 11rem; } .card { margin-left: auto; margin-right: auto; width: 35%; height: 38rem; min-width: 21rem; }
Additionally it would be better if you add the
.card
as direct child ofmain
instead of nesting insidesection
.- Now your component has been properly centered
.
I hope you find this helpful š Above all, the solution you submitted is great !
Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord