@Ezekiel225
Posted
Hello there 👋 @ahmed-shahat.
Good job on completing the challenge !
Your project looks really good!
I have a suggestion about your code that might interest you.
📌 First: Use <main> to wrap the main content instead of <div>.
Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.
Consider adding a min-height of 100vh to the body element so as to centralize your project.
body {
min-height: 100vh;
align-items: center;
display: flex;
justify-content: center;
}
There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.
I hope this suggestion is useful for future projects.
Keep up the excellent work and continue to challenge yourself with new projects. Your progress is impressive, and each project is a step forward in your front-end development journey! 🚀🌟.
Other than that, great job!
Happy coding.
@ahmed-shahat
Posted
@Ezekiel225 helloo ,, Thanks for stopping by and thanks for the advice I will save it well
