Design comparison
Solution retrospective
Helloooo Community , I hope u are doing good this is my 4th solution i tried to make it good I learned how to hover elements using CSS, please take a look at it and I will be waiting for your advices in the comments thank U all. question: I used height:100vh; is it okay and why does it Appear so big in the screenshot what is the used height in the front-end mentor challengs?
Community feedback
- @danielmrz-devPosted 9 months ago
Hello @chemsodev!
Your solution looks excelent!
I have just one suggestion:
š In order to make your HTML code more semantic, don't skip heading levels - start with
<h1>
, then use<h2>
, and so on.Unlike what most people think, it's not just about the size and weight of the text.
-
The
<h1>
to<h6>
tags are used to define HTML headings. -
<h1>
defines the most important heading. -
<h6>
defines the least important heading. -
Only use one
<h1>
per page - this should represent the main heading/title for the whole page.
All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful2@chemsodevPosted 9 months ago@danielmrz-dev tysm mr daniel I was waiting for your comment ,well U are right I thought they are only for visual like I didn't think that it was this important ,thanks again i will try to edit it or submit another solution.
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord