Design comparison
Solution retrospective
I have made a concerted effort to optimize the CSS to the best of my ability.
What challenges did you encounter, and how did you overcome them?I recently discovered that we can modify the cursor using cursor: url('file location');, which was new to me. I experimented with this feature and implemented it in this code.
Community feedback
- @StroudyPosted about 2 months ago
Awesome job tackling this challenge! You’re doing amazing, and I wanted to share a couple of suggestions that might help refine your approach…
-
Using a
<main>tag inside the<body>of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content. -
I would put these into a
<ul> <li>, and the text should be wrapped with a<a>so it is accessible with a keyboard using the tab key, Using an<a>tag for navigation is semantically correct, improves accessibility for screen readers, and ensures consistent behavior across browsers, unlike a<button>or a<div>not intended for links.
<button type="button">GitHub</button> <button type="button">Frontend Mentor</button> <button type="button">LinkedIn</button> <button type="button">Twitter</button> <button type="button">Instagram</button>-
For future project, You could downloading and host your own fonts using
@font-faceimproves website performance by reducing external requests, provides more control over font usage, ensures consistency across browsers, enhances offline availability, and avoids potential issues if third-party font services become unavailable. Place to get .woff2 fonts -
I think you can benefit from using a naming convention like BEM (Block, Element, Modifier) is beneficial because it makes your CSS more organized, readable, and easier to maintain. BEM helps you clearly understand the purpose of each class, avoid naming conflicts, and create reusable components, leading to a more scalable codebase. For more details BEM,
You’re doing fantastic! I hope these tips help you as you continue your coding journey. Stay curious and keep experimenting—every challenge is an opportunity to learn. Have fun, and keep coding with confidence! 🌟
Marked as helpful0@Jyoti-BhandariPosted about 2 months ago@Stroudy hey, I implemented many of the suggestions you provided in my new project, "Responsive Single Price Grid Component." I would appreciate it if you could take a look and provide your feedback. Thank you for your helpful advice.
0 -
- @MikDra1Posted about 2 months ago
If you want to make your card responsive with ease you can use this technique:
.card { width: 90%; max-width: 37.5rem; }On the smaller screens card will be 90% of the parent (here body), but as soon as the card will be 37.5rem (600px) it will lock with this size.
Also to put the card in the center I advise you to use this code snippet:
.container { display: grid; place-items: center; }Hope you found this comment helpful 💗💗💗
Good job and keep going 😁😊😉
Marked as helpful0@Jyoti-BhandariPosted about 2 months ago@MikDra1 Hey thanks. I will try these things to implement in my code.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord