Social Link Profile

Community feedback

• 

  Alok Suman•2,380

  @Alokray007Posted 9 months ago

  Hello there 👋 @p1nu

  Good job on completing the challenge !

  Your project looks really good!

  I have a suggestion about your code that might interest you.

  There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.

  I hope this suggestion is useful for future projects.

  Other than that, great job!

  Happy coding.

  Marked as helpful

  1
• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 9 months ago

  Hello @p1nu!

  Your solution looks great!

  I have a suggestion for improvement:

  • Use <main> to wrap the main content instead of <div>.

  📌 Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.

  This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  Also, despite @Ezekiel225's comment, I have another perspective:

  The challenges here are made to help us improve our skills, but they are not meant to be done 100% as the original design. You can add a little customization whenever possible! I always do it on my projects. Of course it's good for you trying to match the original, but you are free to customize it 😊

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  1
• 

  Manith112•860

  @Manith112Posted 9 months ago

  Wow you better from day to day mate

  1
• 

  Olaniyi Ezekiel•7,580

  @Ezekiel225Posted 9 months ago

  Hey @p1nu nice work !

  I noticed that you've added your own details in this design that's good, but here is a thing, please try to match the font, font size, box sizing and most important responsive layout as per the design provided in the template.

  I hope you will take this feedback in a positive manner.

  Happy coding.

  1