Design comparison
Solution retrospective
css box model learned
What challenges did you encounter, and how did you overcome them?css
Community feedback
- @DylandeBruijnPosted 4 months ago
@Deepa-Vimal
Hiya! 👋
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve ✍️
-
You could add a
min-height: 100vh
to yourbody
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
-
I suggest using clear descriptive CSS classes like
.card
,.card-title
and.card-description
. -
Try using semantic HTML elements like
main
,section
andarticle
. -
Try using using relative CSS units like
rem
andem
they make your layout more adaptable. -
Try putting your links in a list (
ul
) to make your code more semantic. -
Try using an
a
tag instead of abutton
for your links. -
You have some unused Flexbox properties on your container.
I hope you find my feedback helpful! 🌟
Let me know if you have more questions and I'll do my best to answer them. 🙋♂️
Happy coding! 😎
Marked as helpful0@Deepa-VimalPosted 4 months ago@DylandeBruijn,
Thank you so much, DylandeBruijn. I'm a beginner in UI development, and your feedback is invaluable. I will surely consider the above-mentioned suggestions in my next attempt. Could you please suggest some lessons or resources for learning CSS in depth and best practices?
Thank you once again!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord