Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social Link Page

@samukagomesdv

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Todo comentário será bem vindo!

Any comment will be welcome!

Community feedback

P

@perfidev

Posted

Very well, my friend! It looks great! Here are some suggestions:

  • I would add "href" to the <a> tags because they are links and for best practices.
  • I would include a <nav> tag with a <ul> list and place the <a> links inside <li> tags, as it adds semantics since you are navigating through the links.
  • I would set the body as display: flex to center your <div>.
<div class="box-botoes">
    <nav>
        <ul>
            <li><a href="https://github.com">Github</a></li>
            <li><a href="https://frontendmentor.io">Frontend Mentor</a></li>
            <li><a href="https://linkedin.com">LinkedIn</a></li>
            <li><a href="https://twitter.com">Twitter</a></li>
            <li><a href="https://instagram.com">Instagram</a></li>
        </ul>
    </nav>
</div>

Marked as helpful

0

@samukagomesdv

Posted

Thanks for the sugestion! @raphaelperfi

1
Daniel 🛸 44,270

@danielmrz-dev

Posted

Fala @samukagomesdv!

Seu projeto está excelente!

Tenho uma sugestão:

📌 Use <main> pro conteúdo principal ao invés de uma <div>.

Tags como <div> e <span> são exemplos típicos de elementos HTML não-semânticos. Elas servem apenas como containers para o conteúdo, mas não indicam qual o tipo desse conteúdo e nem o papel que ele desempenha na página.

Essas mudanças de tag geram pouco ou nenhum impacto visual mas tornam o seu código HTML mais semântico e melhoram a otimização SEO e acessibilidade do projeto.

Espero que ajude!

Fora isso, ótimo trabalho!

0

@samukagomesdv

Posted

Olá, @danielmrz-dev!

Bacana, obrigado pela dica. Estou aprendendo e aos pouquinhos melhorando esses detalhes!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord