Marcin Mikos• 50
@M-Mikos
Posted
Hi! Thank for your solution, let me share some tips :
- Semantic HTML: Since buttons are similar, repetitive elements next to each other, you could consider tagging them in
<li>tag, wrapped in<ul>parent element. - Sass file structure: You may be interested in implementing elements of the 7-1 pattern in your project, in order to more clearly structure your .scss files (https://sass-guidelin.es/#chapter-architecture)
- Units: Using REM units to specify all dimensions (except very small dimensions such as border-width: 1px) is considered a good practice because of the ease of implementing responsiveness. With REM units, all you need to do is change the font-size value of the root element (html element), and all dimensions dependent on these units will automatically scale. (https://www.freecodecamp.org/news/css-units-when-to-use-each-one/)
Good luck in your future work!
0
