Skip to content
Submitted 3 months ago

Social Link Card with Semantic HTML and CSS

Keiner Mendoza•240
@keinermendoza
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social links profile
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

What makes me feel better is having been able to recreate the design without having access to the design file in Figma

Community feedback

  • geomydas•1,440
    @geomydasPosted 3 months ago

    After looking at your code, here is my feedback:

    HTML

    1. Remove both the article and nav tags. The article tags is often used in a news setting such as news websites, blog posts and etc. It makes no sense to use it here. The nav tag is used for internal links/pages and not external links such as linking to another website

    CSS

    1. For me, the CSS seems to be following best practices but it is quite a bit hard to maintain. I suggest you take a look at the BEM methodology for this so you can name better classes inside the HTML
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord