Submitted 5 months ago

Social link card using HTML and CSS

Achara Chisom Solomon• 520

@AcharaChisomSolomon

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

Social links profile

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Have to learn the box model more intuitively.

What challenges did you encounter, and how did you overcome them?

knowing what tag to wrap within the other.

What specific areas of your project would you like help with?

Nothing.

Community feedback

Thomas Dimnet• 250

@tdimnet

Posted 5 months ago

Hey,

Nice work!

It seems you've used BEM when coding your project and it's both great and really interesting. However, it doesn't seem quite correct and that you confuse block and element. Let me give you an example:

<div class="user__links">
  <p class="user__link">
    <a href="https://github.com/AcharaChisomSolomon" target="_blank">
      GitHub
    </a>
  </p>
//
</div>

It should be user-links then user-links-link or something such as user-description and then user-description-link.

I've found cool that you used: target="_blank" attribute. You could use the rel attribute if you want to be more SEO friendly :).

Other than that, nice work!

Marked as helpful

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord