Design comparison
Solution retrospective
well I was supposed to implement links which would lead to my socials, but in here they are just p tags, so they won't lead ya anywhere,
What challenges did you encounter, and how did you overcome them?a LOT of em , with div overflowing, learning about max heights, changing body tag's default padding and margin to 0 so that it doesn't overflow
What specific areas of your project would you like help with?help with css stuff
Community feedback
- @danielmrz-devPosted 6 months ago
Hello there!
Congrats on completing the challenge! ā
Your solution looks great!
š It's recommended to use semantic HTML elements like
<ul>
and<li>
for creating lists. This ensures that your code is more accessible, maintainable, and semantically meaningful.Here's and example on how you can refactor your code:
After Refactoring
<ul class="list-container"> <li><a href="#">Github</a></li> <li><a href="#">Frontend Mentor</a></li> <li><a href="#">LinkedIn</a></li> ... </ul>
By using
<ul>
and<li>
, you convey the structure of your content more clearly, making it easier for screen readers and search engines to understand. Additionally, it aligns with best practices for HTML semantics.I hope you find this helpful!
Keep up the excellent work!
0 - @Aayan16Posted 6 months ago
Hey! I just completed this project. I implemented the links in the project and also the site is responsive. Works on all kinds of devices. If u want to, take a look at it. I am also a beginner learning right now and we could connect to learn together. Hit me up if interested.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord