@TedJenkler
Posted
Hi @rahulmourya336,
Nice project! Here are a few suggestions:
I noticed that there are too many containers (i.e., <div> elements). To simplify your layout, you can make the <body> a flex container with align-items: center and justify-content: center. Use one main card with flex-direction: column to stack all content without unnecessary nesting. This approach will greatly improve your SEO and accessibility, and also make your code more readable and maintainable, especially for larger projects. Additionally, you can use the <footer> element for the Frontend Mentor footer.
Another thing I noticed is that you don’t use appropriate HTML tags like <h2> in your component. Try to use the correct HTML tags for structure to improve SEO, accessibility, and readability.
I also noticed that you are using <button> elements for links. <button> should only be used when you have a form or need to invoke JavaScript functionality. For links to external sites like GitHub, use <a> tags instead.
Keep up the great work!
Best, Teodor
Marked as helpful