Skip to content
Submitted 3 months ago

Social Link Card

Rahul Mourya•440
@rahulmourya336
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social links profile
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Teodor Jenkler•3,820
    @TedJenklerPosted 2 months ago

    Hi @rahulmourya336,

    Nice project! Here are a few suggestions:

    I noticed that there are too many containers (i.e., <div> elements). To simplify your layout, you can make the <body> a flex container with align-items: center and justify-content: center. Use one main card with flex-direction: column to stack all content without unnecessary nesting. This approach will greatly improve your SEO and accessibility, and also make your code more readable and maintainable, especially for larger projects. Additionally, you can use the <footer> element for the Frontend Mentor footer.

    Another thing I noticed is that you don’t use appropriate HTML tags like <h2> in your component. Try to use the correct HTML tags for structure to improve SEO, accessibility, and readability.

    I also noticed that you are using <button> elements for links. <button> should only be used when you have a form or need to invoke JavaScript functionality. For links to external sites like GitHub, use <a> tags instead.

    Keep up the great work!

    Best, Teodor

    Marked as helpful
    1
  • Steven Stroud•11,870
    @StroudyPosted 3 months ago

    Hey, Great solution you should be proud of, A few things I noticed,

    • Missing a <meta> description tag for SEO purposes,
    • It is best practice to have a <main> tag inside your body highlighting the main section.
    • You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
    • Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
    • ‍Using max-width: 100% or min-width: 100% is way more responsive then just width:100%, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail.
    • You should avoid using px as it is an absolute unit and not a responsive unit like rem or em, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels.
    • Another great resource for px to rem converter.
    • Having better alt="" descriptions for accessibility is a must check this out Write helpful Alt Text to describe images,

    I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻

    Marked as helpful
    0
    Rahul Mourya•440
    @rahulmourya336Posted 3 months ago

    @Stroudy

    Thank you for taking your time to review the code! Noted. I'll improve.

    Cheers, Rahul

    1
    Steven Stroud•11,870
    @StroudyPosted 3 months ago

    @rahulmourya336, You did nothing wrong just some accessibility changes, Great solution overall 😁

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord