Social Link Card

Community feedback

• 

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 4 months ago

  @Anas-95

  Hiya! 👋

  Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

  Things you could improve ✍️

  • I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

  • You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

  • Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.

  • I suggest using clear descriptive CSS classes like .card, .card-title and .card-description.

  • Try using semantic HTML elements like main, section and article.

  • Try using using relative CSS units like rem and em they make your layout more adaptable.

  • You don’t need to put width: 100% on block elements, they already take up the full width of their parents by default.

  • Try putting your links in a list (ul with li elements) to make your code more semantic.

  I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟

  Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

  Happy coding! 😎

  Marked as helpful

  0

  ---

  

  Anas - Front End Developer student•140

  @Anas-95Posted 4 months ago

  @DylandeBruijn Hi Dylan!

  Thank you for your feedback!! Appreciate it!

  I will learn more about semantic HTML, I forgot about using CSS variables, you are right! it's more efficient! I will learn too about rem and em and when to use it!

  Happy coding too!! :D

  0