
Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
In this project perhaps would modify the form of the links
What challenges did you encounter, and how did you overcome them?The challenge of this project was in deciding how to build the links
What specific areas of your project would you like help with?I would ask for help or feedback on how to build the links for this project, Is it okay to build them or is there a more efficient way to do it?
Please log in to post a comment
Log in with GitHubCommunity feedback
- @Blackpachamame
¡Muy buen trabajo! 😎
📌 Algunas sugerencias
- Por semántica HTML, podrías cambiar tu
<div class="attribution">
por<footer class="attribution">
- El
margin: 0
en lugar de colocarlo en elbody
puedes colocarlo en el selector universal*
para que aplique a todos los elementos y no solo albody
- En tu
main
tienes unwidth: 99vw
que, en primer lugar, no recomiendo usar vw porque suele generar un scroll horizontal y en segunda, es innecesario en este caso - También te recomiendo usar
min-height
en lugar deheight
, ya que, de esta forma evitas que el contenido quede cortado si el alto de la pantalla es menor al del contenido
- Por semántica HTML, podrías cambiar tu
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord