Social link

Community feedback

• 

  P

  Caitlin Donahue•120

  @DonahuecPosted 2 months ago

  Colors and Text Styling look good.

  Potential Areas for Improvement:

  • you'll have better luck with the full page layout if you put the flex styling on an element like main instead of the body. Generally body styles should be limited to things that affect the whole page, such as fonts and background color.
  • instead of setting explicit height and width, it is better to rely on flexible widths like 'fit-content' and allow the element to adapt it's own height. this will help with adapting to smaller screens. For instance, my laptop has a shorter screen, which caused the card to overflow off of the screen due to the explicit height and margins.
  • you can avoid some repeated styling by moving the base font styles (i.e. font family) onto the body tag
  • semantically you should use an h1 rather than h2 since it is the primary header on the page.

  Marked as helpful

  0