Social-fem-poorijak

Community feedback

• 

  Sylwia•240

  @LesSylPosted 18 days ago

  Hi! Your solution looks grate. I have a few suggestions:

  1. the <a href ="">attribute should specify the destination of the link, you can read more here: w3- <a href>, MDN- <a href>,

  2. the <img> tag should have the <alt> attribute completed. It is important for SEO. HTML: A good basis for accessibility,

  3. it is good practice to use rem and em to specify font size and margins and padding. More information here: CSS values and units,

  4. it is good practice to use a naming convention such as BEM (Block, Element, Modifier) is beneficial as it makes the CSS more organised, readable and easier to maintain. BEM helps to clearly understand the purpose of each class, avoid naming conflicts and create reusable components, leading to a more scalable code base. More details here: BEM.

  Good luck!

  0