Submitted over 1 year ago
Snap Intro Section with Dropdown Navigation, React + SCSS
@semperprimum
Design comparison
SolutionDesign
Solution retrospective
I would greatly appreciate any feedback you may have!
Some parts of the code I'm unsure of:
- The backdrop that appears when the hamburger menu on mobile is toggled. I had to use an empty div. Is there a better way to achieve this?
- The positioning of the main content. To name a few things, the main content wrapper uses a negative margin because the header was slightly too tall. I used a
float: right
on an image to stick it to the right of the container. I could have used flex, but float seemed to work just like I wanted it to, and it saved me a couple of lines. I heard from somebody on the internet that we shouldn't use float properties, so that's why I'm unsure about using it. - How is my folder structure?"
Community feedback
- @Aimal-125Posted over 1 year ago
In your CSS code, give body element height of 120 or 150vh by using media query with
max-height: 400px;
so that your solution looks good on screens with small heights.0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord