Design comparison
Solution retrospective
I have been able to reproduce the design quite quickly while still maintaining, I think, a decent similarity
What challenges did you encounter, and how did you overcome them?I had difficulties with making my design completely responsive.
What specific areas of your project would you like help with?I know that there is a better way to do the tag background, but I am not sure how.
Community feedback
- @DylandeBruijnPosted 4 months ago
@keethesh
Hiya! 👋
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve ✍️
-
I suggest adding a bit of
padding
to yourbody
element so the card has some space around it on smaller viewports. -
You could add a
min-height: 100vh
to yourbody
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
I suggest using clear descriptive CSS classes like
.card
,.card-title
and.card-description
. -
Try using semantic HTML elements like
main
,section
andarticle
. -
Try using using relative CSS units like
rem
andem
they make your layout more adaptable. -
I suggest using
px
for thewidth
of the card. -
I suggest using proper tags for you headings and text, like
h1
andp
. -
You have some overflow issues on smaller viewports.
I hope you find my feedback helpful! 🌟
Let me know if you have more questions and I'll do my best to answer them. 🙋♂️
Happy coding! 😎
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord