Sleek NFT Component using flexbox and custom properties

Community feedback

• 

  Agata Liberska•3,995

  @AgataLiberskaPosted almost 3 years ago

  Hi @devshot-dotcom, some nice work here :)

  The card looks great, but I would take a closer look at the semantic tags you're using. <article> is a good choice I think, and it can definitely have a <header> and a <footer>, but <main> should be reserved for te main content of the page (so you could have body > main > article > header). In this case, I'm not sure <header> is the best choice, unless you include the main text as the heading (header should introduce the content and I'm not sure that the image does it on its own). The anchor tag you have should definitely be wrapped in a h2-h6 (let's leave h1 for the heading of the hypothetical page this would appear on).

  I'd also review the alt text on your images - rather than passing a message, it should really just describe what you can see in the image.

  Hope this helps :)

  0