Skip to content
Submitted over 2 years ago

Skilled e-learning landing page

Dave Quah•660
@Milleus
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Skilled e-learning landing page
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello everyone,

I'd appreciate it if you could share your feedback on my solution.

One of the things I've learnt from this was how to display different images for different device pixel density with <picture> and <source>. Also learnt how to test this with the browser's responsive design mode (use the DPR setting).

P.S. I use newer CSS properties such as padding-inline and margin-block which may not work on all browsers. Thank you @Deevyn9 for testing and informing. 🙇‍♂️🙏

Community feedback

  • Divine Obeten•2,415
    @Deevyn9Posted over 2 years ago

    Hi Dave, everything Looks great, you need to add padding/margin to the hero section and footer on the mobile view

    Happy coding 😃

    Marked as helpful
    0
    Dave Quah•660
    @MilleusPosted over 2 years ago

    Hi @Deevyn9 👋

    I've intentionally removed the padding on the image in the hero section as the image already comes with a huge spacing. Are you suggesting that there should be more padding/margin?

    Also, the footer does not have a padding but the div within it does. Do you mean that the padding/margin should be adjusted as well?

    I'd appreciate it if you could share a screenshot of the issue with me on Slack if possible. Thank you!!

    0
    Divine Obeten•2,415
    @Deevyn9Posted over 2 years ago

    @Milleus that would be great, send i link i can contact you with

    Marked as helpful
    0
    Dave Quah•660
    @MilleusPosted over 2 years ago

    @Deevyn9 I'm @Milleus on frontend mentor slack. Thank you!

    0
    Divine Obeten•2,415
    @Deevyn9Posted over 2 years ago

    @Milleus I’m not on the slack, I’ll try joining the server now

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord